Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): remove duplicate objectID #2113

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix(specs): remove duplicate objectID #2113

merged 1 commit into from
Oct 12, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 12, 2023

🧭 What and Why

this removes the warning discovered by @shortcuts, two parameters were named objectID and redocly didn't like that

@millotp millotp self-assigned this Oct 12, 2023
@millotp millotp requested a review from a team as a code owner October 12, 2023 09:58
@millotp millotp requested review from aallam and shortcuts October 12, 2023 09:58
@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit a8eee88
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6527c35a9f101900086b6442
😎 Deploy Preview https://deploy-preview-2113--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 12, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!! so weird it didn't threw an error

@millotp
Copy link
Collaborator Author

millotp commented Oct 12, 2023

so weird it didn't threw an error

it's because it's just a path parameter, it doesn't generate a model like other objects, so the name is transparent

@millotp millotp merged commit a5ff0a7 into main Oct 12, 2023
20 checks passed
@millotp millotp deleted the fix/objectID-duplicate branch October 12, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants