-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): update Insights API spec #2376
Conversation
Add the value property to some events, sort attributes required/optional, add examples for these new events.
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Ah, I guess, I should write some tests. |
hey @kai687, thanks for the PR, taking a look! |
I decided to remove the The |
03ace57
to
c28a97e
Compare
the last issue remaining is that the echo interceptor for java requires the method to return the request, but since there's no payload we can't do that, will try to find a fix for that (cc @millotp) |
working on a C# fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally green ! gg everyone
🧭 What and Why
Update the API spec for the Insights API we wanted to make an update to 'Purchase' events.
We want to remove the event-level
queryID
parameter in the documentation for 'Purchase' events, and rather have object-levelqueryID
s. (Otherwise, it's too confusing).🎟 JIRA Ticket: n/a
Changes included:
queryID
parameter from the 'Purchase' events.🧪 Test
n/a