Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clients): add missing clients #2479

Merged
merged 5 commits into from
Jan 5, 2024
Merged

feat(clients): add missing clients #2479

merged 5 commits into from
Jan 5, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jan 5, 2024 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1747

Changes included:

  • add missing abtesting client to Go
  • add missing ingestion client to PHP and Java
  • cleanup openapitools in order to generate it

@shortcuts shortcuts self-assigned this Jan 5, 2024
@shortcuts shortcuts requested a review from a team as a code owner January 5, 2024 11:07
@netlify Netlify
Copy link

netlify bot commented Jan 5, 2024 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit efae311
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65980c469f8d1c0008c2c43c
😎 Deploy Preview https://deploy-preview-2479--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 5, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

millotp
millotp approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it !

@shortcuts shortcuts merged commit 461796b into main Jan 5, 2024
27 checks passed
@shortcuts shortcuts deleted the feat/add-missing-clients branch January 5, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @millotp