Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clients): deserialize in e2e and SFFV response #2500

Merged
merged 4 commits into from
Jan 9, 2024
Merged

feat(clients): deserialize in e2e and SFFV response #2500

merged 4 commits into from
Jan 9, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jan 9, 2024 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1748

Changes included:

We now deserialize responses in the generated models for Python, pydantic would raise an error if it failed

Also fix the search for facet values response which was missing properties

@shortcuts shortcuts self-assigned this Jan 9, 2024
@shortcuts shortcuts marked this pull request as ready for review January 9, 2024 08:52
@shortcuts shortcuts requested a review from a team as a code owner January 9, 2024 08:52
@netlify Netlify
Copy link

netlify bot commented Jan 9, 2024 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit d2ac2ed
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/659d14eee53c0b00086f3252
😎 Deploy Preview https://deploy-preview-2500--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 9, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts
Copy link
Member Author

2500

millotp
millotp reviewed Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the statusCode assertion has disappeared from the CTS ?

@shortcuts
Copy link
Member Author

the statusCode assertion has disappeared from the CTS ?

only for endpoints with body assertions since the deserialized object doesn't contain it, but the set_settings still has it for example!

@shortcuts shortcuts requested a review from millotp January 9, 2024 09:42
@shortcuts shortcuts enabled auto-merge (squash) January 9, 2024 09:43
millotp
millotp approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@shortcuts shortcuts merged commit ae20258 into main Jan 9, 2024
28 checks passed
@shortcuts shortcuts deleted the feat/python-deserialize-e2e branch January 9, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @millotp