Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): correct url for monitoring client #2569

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 18, 2024

🧭 What and Why

Following #2561, use the correct url for java, and rework the generators to use the already read spec file, and the correct types for servers.

@millotp millotp self-assigned this Jan 18, 2024
@millotp millotp requested a review from a team as a code owner January 18, 2024 15:04
Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit ec36c17
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65a93e1d2e904d00080b99eb
😎 Deploy Preview https://deploy-preview-2569--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 18, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@@ -90,6 +90,12 @@ private String typeToName(String content) {
return content.trim().replace("[", "Of").replace("]", "").replace(".", "").replace(", ", "");
}

@Override
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did the client worked without this ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was called line 80 before, I just changed the way the function work so I had to move it here

Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puuurfect !

@millotp millotp enabled auto-merge (squash) January 18, 2024 15:16
@millotp millotp merged commit 30d54e7 into main Jan 18, 2024
28 checks passed
@millotp millotp deleted the fix/java-monitoring branch January 18, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants