fix(clients): support the rest of the languages #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Fluf22
previously approved these changes
Jan 18, 2024
morganleroi
previously approved these changes
Jan 18, 2024
oops, I thought you had many changes so I didn't wanted to cause merge conflict with you |
|
I have indeed, I'll do it later 😁 |
shortcuts
reviewed
Jan 18, 2024
| } |
There was a problem hiding this comment.
ahah I only run the linter on the tests templates, the rest it's okay
There was a problem hiding this comment.
shortcuts
reviewed
Jan 18, 2024
| @@ -11,7 +11,7 @@ class Snippet{{client}} { | |||
| {{#snippet}} | |||
| suspend fun snippetFor{{#lambda.pascalcase}}{{method}}{{/lambda.pascalcase}}() { | |||
| // Initialize the client | |||
| val client = {{client}}(appId = "YOUR_APP_ID", apiKey = "YOUR_API_KEY"{{#hasRegionalHost}}, region = "YOUR_APP_ID_REGION"{{/hasRegionalHost}}) | |||
| val client = {{client}}(appId = "YOUR_APP_ID", apiKey = "YOUR_API_KEY"{{#hasRegionalHost}}, region = "YOUR_REGION"{{/hasRegionalHost}}) | |||
There was a problem hiding this comment.
it's the application region not the user region
There was a problem hiding this comment.
yeah I forgot to revert this one, fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Do the rest of the languages for #2561 , and add a new variable to make the templates more readable.