Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): correct searchSynonyms parameters #2595

Merged
merged 17 commits into from
Jan 23, 2024
Merged

Conversation

morganleroi
Copy link
Contributor

@morganleroi morganleroi commented Jan 22, 2024

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

The parameters of the searchSynonyms method are in fact body parameters and not query parameters, this PR also fixes the browse helpers

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 5de0b6c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65afdc5a0078b30008285d4d
😎 Deploy Preview https://deploy-preview-2595--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@morganleroi morganleroi changed the title change searchSynonyms spec feat(specs): change searchSynonyms Jan 22, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 22, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@morganleroi
Copy link
Contributor Author

@millotp @shortcuts do you an idea why this change broke the CTS generation ?

@shortcuts shortcuts changed the title feat(specs): change searchSynonyms fix(specs): change searchSynonyms Jan 23, 2024
@shortcuts shortcuts changed the title fix(specs): change searchSynonyms fix(specs): correct searchSynonyms parameters Jan 23, 2024
@shortcuts shortcuts marked this pull request as ready for review January 23, 2024 15:59
@shortcuts shortcuts requested a review from a team as a code owner January 23, 2024 15:59
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!! gg

@shortcuts shortcuts merged commit 379fbc5 into main Jan 23, 2024
29 checks passed
@shortcuts shortcuts deleted the fix/specs-synonym branch January 23, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants