Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): update query suggestions unauthorized response example #2606

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

alphonseb
Copy link
Contributor

🧭 What and Why

Follow up of #2604
Updating the QS Unauthorized examples to remove the "Missing Admin API Key" one and replace it with "Missing ACL".

I'm not sure if I followed the proper formatting, please let me know! I also assumed that everything under "bundled" was generated so I did not touch anything there.

@alphonseb alphonseb requested a review from a team as a code owner January 26, 2024 10:35
@alphonseb alphonseb requested review from damcou and millotp January 26, 2024 10:35
Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 467c9af
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65b38bc776faab0008ae338a
😎 Deploy Preview https://deploy-preview-2606--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 26, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@alphonseb alphonseb changed the title feat(qs): update unauthorized response example feat(specs): update unauthorized response example Jan 26, 2024
@alphonseb alphonseb changed the title feat(specs): update unauthorized response example feat(specs): update query suggestions unauthorized response example Jan 26, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks again ! You're right, files under bundled are generated, you modified the correct file !
We don't use examples yet in the generated code, but they will be used for the documentation hopefully

@millotp millotp merged commit 872ab29 into main Jan 26, 2024
27 checks passed
@millotp millotp deleted the feat/qs/update-example branch January 26, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants