feat(java): add fat jar APIC-262 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
requested review from
a team,
eunjae-lee and
damcou
and removed request for
a team
damcou
reviewed
Apr 26, 2022
perfect then no explanation needed 😁 This includes all the dependencies such as HTTP client and JSON parser, that mean this jar can be used as a standalone without a build system that will download the dependencies, and this is required by some big company |
shortcuts
pushed a commit
that referenced
this pull request
Apr 26, 2022
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Apr 26, 2022
algolia/api-clients-automation#272 Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
This was referenced Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-262
Include fat jar including all libs requested by some clients, this make the size of the jar go from
500KBto3.5MBIt can be accessed has
com.algolia.algoliasearch-core-all:0.0.1-SNAPSHOTChanges included:
🧪 Test
./gradle/gradlew -p clients/algoliasearch-client-java-2 assemble