fix(specs): add missing attributes for CT Source update #2792
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| fallbackIsInStockValue: | ||
| type: boolean | ||
| default: true | ||
| description: > | ||
| Determines the value that will be stored in the Algolia record if there's no inventory information on the product. |
There was a problem hiding this comment.
This means during an update, it will default to true...
Are you sure this is the wanted behavior?
There was a problem hiding this comment.
With the dashboard, the value should always be sent, but you're right, let's remove the default value on update
There was a problem hiding this comment.
Then you should add it to the required array
There was a problem hiding this comment.
(and removed, see below)
There was a problem hiding this comment.
This means during an update, it will default to true... Are you sure this is the wanted behavior?
We don't (and shouldn't) use default values in the API client, if the API defaults to true it's normal to mention it here
| customFields: | ||
| $ref: '#/CommercetoolsCustomFields' | ||
| required: |
There was a problem hiding this comment.
the goal of the update is not to have required properties
There was a problem hiding this comment.
Removed, please, I just want to close my PR about the custom fields...
🧭 What and Why
🎟 JIRA Ticket: DI-1788
Changes included:
urlandfallbackIsInStockValuefor CT Source Update