-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clients): add recommend to algoliasearch #2860
Conversation
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
d9ac12f
to
5064d64
Compare
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
37803cf
to
c083303
Compare
the generated comment is the part that should interest you @Haroenv @aymeric-giraudet #2860 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing to adds, looks good !
Does it make sense to still have the standalone recommend client ? should it be merged with the search client instead?
c1c3054
to
7b318fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the idea of this PR, but I don't know this code base well enough to give a real assessment on whether it's implemented correctly
Thanks for the review :) it was mostly to let you see the progress of it, in term of implementation it will end up with https://667930f9faf0e278fa0f78b2--api-clients-automation.netlify.app/specs/recommend#tag/recommendations/operation/getRecommendations in the lite client, exactly with the same signature (and @aymeric-giraudet is working on providing a legacy signature support too) |
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/FX-2774 https://algolia.atlassian.net/browse/DI-2478
Changes included:
related to #2834