Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): add recommend to algoliasearch #2860

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Mar 12, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/FX-2774 https://algolia.atlassian.net/browse/DI-2478

Changes included:

related to #2834

As we're trying to unify FX libraries, we want to avoid requiring users to import a bunch of different packages.
We've made those changes to v4 : algolia/algoliasearch-client-javascript#1509

@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 12, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link

github-actions bot commented Mar 12, 2024

@github-actions github-actions bot temporarily deployed to pull request March 12, 2024 19:06 Inactive
@shortcuts shortcuts force-pushed the feat/algoliasearch-recommend branch from d9ac12f to 5064d64 Compare June 20, 2024 09:05
shortcuts and others added 2 commits June 20, 2024 11:43
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
@shortcuts shortcuts marked this pull request as ready for review June 20, 2024 10:00
@shortcuts shortcuts requested a review from a team as a code owner June 20, 2024 10:00
@shortcuts shortcuts force-pushed the feat/algoliasearch-recommend branch from 37803cf to c083303 Compare June 20, 2024 11:23
@github-actions github-actions bot temporarily deployed to pull request June 20, 2024 12:38 Inactive
@shortcuts
Copy link
Member Author

the generated comment is the part that should interest you @Haroenv @aymeric-giraudet #2860 (comment)

millotp
millotp previously approved these changes Jun 20, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing to adds, looks good !
Does it make sense to still have the standalone recommend client ? should it be merged with the search client instead?

@github-actions github-actions bot temporarily deployed to pull request June 21, 2024 08:48 Inactive
@shortcuts shortcuts force-pushed the feat/algoliasearch-recommend branch from c1c3054 to 7b318fb Compare June 24, 2024 08:25
@shortcuts shortcuts enabled auto-merge (squash) June 24, 2024 08:26
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the idea of this PR, but I don't know this code base well enough to give a real assessment on whether it's implemented correctly

@shortcuts
Copy link
Member Author

shortcuts commented Jun 24, 2024

I agree with the idea of this PR, but I don't know this code base well enough to give a real assessment on whether it's implemented correctly

Thanks for the review :) it was mostly to let you see the progress of it, in term of implementation it will end up with https://667930f9faf0e278fa0f78b2--api-clients-automation.netlify.app/specs/recommend#tag/recommendations/operation/getRecommendations in the lite client, exactly with the same signature

(and @aymeric-giraudet is working on providing a legacy signature support too)

@github-actions github-actions bot temporarily deployed to pull request June 24, 2024 08:55 Inactive
@shortcuts shortcuts merged commit 07e0748 into main Jun 24, 2024
21 checks passed
@shortcuts shortcuts deleted the feat/algoliasearch-recommend branch June 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants