Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): ingestion api reference #2918

Merged
merged 14 commits into from
Mar 28, 2024
Merged

fix(specs): ingestion api reference #2918

merged 14 commits into from
Mar 28, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Mar 25, 2024

🧭 What and Why

Updates the Ingestion API reference, mostly the descriptions.

🎟 JIRA Ticket:

Changes included:

  • List changes

🧪 Test

@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 25, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

🚀 Deployed on https://660567ad61fa90009791f805--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 25, 2024 16:23 Inactive
@kai687 kai687 marked this pull request as ready for review March 25, 2024 16:33
@kai687 kai687 requested a review from a team as a code owner March 25, 2024 16:33
@kai687 kai687 requested review from morganleroi and millotp March 25, 2024 16:33
shortcuts
shortcuts reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work as always!

specs/ingestion/common/destinationParameters.yml Outdated Show resolved Hide resolved
specs/ingestion/common/observabilityParameters.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/common.yml Show resolved Hide resolved
specs/ingestion/common/schemas/destination.yml Show resolved Hide resolved
specs/ingestion/common/schemas/destination.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/event.yml Show resolved Hide resolved
kai687 and others added 4 commits March 25, 2024 17:47
@kai687 @shortcuts
Apply obvious fixes
5943cb5 
Except the discussion about the event type

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
@kai687
fix: support format uuid strings
95e77a6
@kai687
fix: uuid for Java
d5adb02
@kai687
fix: uuids back to strings for now
5103e8b 
Adding support for UUID as variables seems to be more involved.
I really just want to use this as annotation for docs, not as type
validation for the clients.
@github-actions github-actions bot temporarily deployed to pull request March 25, 2024 19:10 Inactive
@kai687 kai687 requested a review from shortcuts March 25, 2024 19:18
@github-actions github-actions bot temporarily deployed to pull request March 26, 2024 09:40 Inactive
@kai687
Copy link
Contributor Author

kai687 commented Mar 28, 2024

@shortcuts could we merge this?

shortcuts
shortcuts approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

@shortcuts
Copy link
Member

(again, thanks a lot for all of your contributions to the specs!)

@shortcuts shortcuts changed the title docs: ingestion api reference fix(specs): ingestion api reference Mar 28, 2024
@github-actions github-actions bot temporarily deployed to pull request March 28, 2024 12:50 Inactive
@shortcuts shortcuts enabled auto-merge (squash) March 28, 2024 12:51
@shortcuts shortcuts merged commit b153b39 into main Mar 28, 2024
25 checks passed
@shortcuts shortcuts deleted the docs/ingestion branch March 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp left review comments

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kai687 @algolia-bot @shortcuts @millotp