Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): query suggestions api #2924

Merged
merged 12 commits into from
Mar 28, 2024
Merged

fix(specs): query suggestions api #2924

merged 12 commits into from
Mar 28, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Mar 26, 2024

🧭 What and Why

Update the spec for the Query Suggestions API.

🎟 JIRA Ticket:

Changes included:

  • Updated the /1/configs API response (there are no API keys returned in the response)
  • Marked fields as nullable: true instead of using a oneOf with null

@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 26, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@kai687 kai687 marked this pull request as ready for review March 28, 2024 10:02
@kai687 kai687 requested a review from a team as a code owner March 28, 2024 10:02
@kai687 kai687 requested review from morganleroi and millotp March 28, 2024 10:02
@kai687
Copy link
Contributor Author

kai687 commented Mar 28, 2024

Don't really know how to fix the failing CTS.
The API response for GET Query Suggestions config includes the appId, so I added the appId as expected response parameter in the CTS. Don't know why it still fails.

@shortcuts
Copy link
Member

Don't really know how to fix the failing CTS. The API response for GET Query Suggestions config includes the appId, so I added the appId as expected response parameter in the CTS. Don't know why it still fails.

I tried calling the API and appId was wrongly cased it seems like 3028a52

@shortcuts shortcuts changed the title docs: query suggestions api fix(specs): query suggestions api Mar 28, 2024
shortcuts
shortcuts previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work

@kai687
Copy link
Contributor Author

kai687 commented Mar 28, 2024

Ah, indeed. I can never remember the proper spelling of anything with an ID :).

@kai687 kai687 requested a review from shortcuts March 28, 2024 19:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited
Loading

🚀 Deployed on https://6605c5b8a3590a25e529e294--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 28, 2024 19:32 Inactive
shortcuts
shortcuts approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome nothing to add!!

@shortcuts shortcuts merged commit 10e08c9 into main Mar 28, 2024
25 checks passed
@shortcuts shortcuts deleted the docs/qs branch March 28, 2024 20:49
Fluf22 pushed a commit that referenced this pull request Mar 30, 2024
@kai687 @shortcuts @Fluf22
fix(specs): query suggestions api (#2924)
ea38f32 
Co-authored-by: shortcuts <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kai687 @algolia-bot @shortcuts