fix(specs): crawler api #2949
Merged
fix(specs): crawler api #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
shortcuts
reviewed
Apr 3, 2024
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
|
@shortcuts can you merge it when you're happy? I don't have permissions to merge PRs here. |
shortcuts
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Update the specs for the Crawler API to be suited as API reference documentation.
🎟 JIRA Ticket:
Changes included:
Only remaining issue is
recordExtractorandlinkExtractorsince those are JavaScript functions as strings. I think it'll be better to document them outside the OpenAPI spec on a separate page.