Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): add usage client #2960

Merged
merged 6 commits into from
Apr 5, 2024
Merged

feat(clients): add usage client #2960

merged 6 commits into from
Apr 5, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1917

Changes included:

follow up of #2954, we can generate the usage client now that the specs is validated

@shortcuts shortcuts self-assigned this Apr 5, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 5, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts marked this pull request as ready for review April 5, 2024 14:14
@shortcuts shortcuts requested a review from a team as a code owner April 5, 2024 14:14
@shortcuts shortcuts requested review from damcou and millotp April 5, 2024 14:14
Copy link

github-actions bot commented Apr 5, 2024

@github-actions github-actions bot temporarily deployed to pull request April 5, 2024 14:29 Inactive
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a confirmation about the file removing process

scripts/pre-gen/removeExistingCodegen.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems perfect
The whole toolchain is awesome

@github-actions github-actions bot temporarily deployed to pull request April 5, 2024 14:59 Inactive
@shortcuts shortcuts merged commit aee3fde into main Apr 5, 2024
25 checks passed
@shortcuts shortcuts deleted the feat/usage-clients branch April 5, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants