Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): update shopify source and task inputs #2987

Merged
merged 6 commits into from
Apr 15, 2024
Merged

feat(specs): update shopify source and task inputs #2987

merged 6 commits into from
Apr 15, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Apr 11, 2024 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-1916

Changes included:

  • Update Shopify source input
  • Update Shopify task input

@Fluf22 Fluf22 self-assigned this Apr 11, 2024
@Fluf22 Fluf22 requested a review from a team as a code owner April 11, 2024 09:21
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 11, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2024 •
edited
Loading

🚀 Deployed on https://6617f2cc259a501f21289ff5--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 11, 2024 10:46 Inactive
kai687
kai687 requested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@kai687 kai687 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me participate! Just a few minor suggestions.

specs/ingestion/common/schemas/source.yml Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Show resolved Hide resolved
specs/ingestion/common/schemas/source.yml Outdated Show resolved Hide resolved
@Fluf22 @kai687
Apply suggestions from code review
021f51e 
Co-authored-by: Kai Welke <kai.welke@algolia.com>
@github-actions github-actions bot temporarily deployed to pull request April 11, 2024 12:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 11, 2024 13:40 Inactive
@Fluf22 Fluf22 requested review from millotp and kai687 April 11, 2024 13:48
@github-actions github-actions bot temporarily deployed to pull request April 11, 2024 14:00 Inactive
millotp
millotp reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last thing

specs/ingestion/common/schemas/task.yml Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request April 11, 2024 14:25 Inactive
@Fluf22 Fluf22 enabled auto-merge (squash) April 11, 2024 15:16
@Fluf22 Fluf22 requested a review from millotp April 12, 2024 05:24
millotp
millotp approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@Fluf22 Fluf22 merged commit 67b0eab into main Apr 15, 2024
24 checks passed
@Fluf22 Fluf22 deleted the feat/shopify-inputs-update branch April 15, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@kai687 kai687 kai687 approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fluf22 @algolia-bot @kai687 @millotp