Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): attribute and index names case sensitive #2990

Merged
merged 4 commits into from
Apr 15, 2024
Merged

fix(specs): attribute and index names case sensitive #2990

merged 4 commits into from
Apr 15, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Apr 11, 2024

🧭 What and Why

It's sometimes not straightforward to know which parts are case-sensitive or not and catches people by surprise.

  • indexName in request bodies are case-sensitive
  • attribute names referring to records, such as searchableAttributes

This change makes this more visible.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 11, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@kai687 kai687 marked this pull request as ready for review April 11, 2024 16:07
@kai687 kai687 requested a review from a team as a code owner April 11, 2024 16:07
@kai687 kai687 requested review from damcou and shortcuts April 11, 2024 16:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 14, 2024 •
edited
Loading

🚀 Deployed on https://661d1ba07e191003372e69e3--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 14, 2024 16:06 Inactive
millotp
millotp approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition !

@github-actions github-actions bot temporarily deployed to pull request April 15, 2024 12:20 Inactive
@millotp millotp merged commit 41121e7 into main Apr 15, 2024
25 checks passed
@millotp millotp deleted the fix/case-sensitiveness branch April 15, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kai687 @algolia-bot @millotp