Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): exhaustiveFacetsCount is not deprecated for sffv #3089

Merged
merged 2 commits into from
May 16, 2024
Merged

fix(specs): exhaustiveFacetsCount is not deprecated for sffv #3089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0806c7f
fix(specs): exhaustiveFacetsCount is not deprecated for sffv
kai687 May 16, 2024
31038f8
fix: type not properties
kai687 May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion specs/search/common/schemas/SearchForFacetValuesResponse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ searchForFacetValuesResponse:
description: Number of records with this facet value. [The count may be approximated](https://support.algolia.com/hc/en-us/articles/4406975248145-Why-are-my-facet-and-hit-counts-not-accurate-).
type: integer
exhaustiveFacetsCount:
$ref: 'SearchResponse.yml#/exhaustiveFacetsCount'
type: boolean
description: |
Whether the facet count is exhaustive (true) or approximate (false).
For more information, see [Why are my facet and hit counts not accurate](https://support.algolia.com/hc/en-us/articles/4406975248145-Why-are-my-facet-and-hit-counts-not-accurate-).
processingTimeMS:
$ref: 'SearchResponse.yml#/processingTimeMS'
9 changes: 3 additions & 6 deletions specs/search/common/schemas/SearchResponse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ baseSearchResponse:
title: typo
description: Whether the typo search was exhaustive (`true`) or approximate (`false`). An approximation is done when the typo search query part takes more than 10% of the query budget (ie. 5ms by default) to be processed (this can happen when a lot of typo alternatives exist for the query). This field will not be included when typo-tolerance is entirely disabled.
exhaustiveFacetsCount:
$ref: '#/exhaustiveFacetsCount'
type: boolean
description: See the `facetsCount` field of the `exhaustive` object in the response.
deprecated: true
exhaustiveNbHits:
type: boolean
description: See the `nbHits` field of the `exhaustive` object in the response.
Expand Down Expand Up @@ -197,11 +199,6 @@ nbPages:
description: Number of pages of results.
example: 1

exhaustiveFacetsCount:
type: boolean
description: See the `facetsCount` field of the `exhaustive` object in the response.
deprecated: true

processingTimeMS:
type: integer
description: Time the server took to process the request, in milliseconds.
Expand Down
Loading