Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clients): chunked batch helper #3154

Merged
merged 6 commits into from
Jun 11, 2024
Merged

fix(clients): chunked batch helper #3154

merged 6 commits into from
Jun 11, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jun 10, 2024 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1970

Changes included:

supersede #3069

ensure clients push the first (if only one) and last batch with the same logic in all clients

@shortcuts shortcuts self-assigned this Jun 10, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 10, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

🚀 Deployed on https://66681340416cf1cd5e35eb1d--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 11, 2024 08:01 Inactive
@shortcuts shortcuts marked this pull request as ready for review June 11, 2024 08:32
@shortcuts shortcuts requested a review from a team as a code owner June 11, 2024 08:32
@shortcuts shortcuts requested review from damcou and millotp June 11, 2024 08:32
millotp
millotp reviewed Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix !

templates/javascript/clients/client/api/helpers.mustache Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 11, 2024 08:44 Inactive
@shortcuts shortcuts requested a review from millotp June 11, 2024 08:51
@shortcuts shortcuts enabled auto-merge (squash) June 11, 2024 08:52
@kai687 kai687 mentioned this pull request Jun 11, 2024
Closed
@github-actions github-actions bot temporarily deployed to pull request June 11, 2024 09:05 Inactive
millotp
millotp approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg !

@shortcuts shortcuts merged commit 3a97fad into main Jun 11, 2024
18 checks passed
@shortcuts shortcuts deleted the fix/clients-chunked-batch branch June 11, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @millotp