Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): rankingInfo required properties #3157

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix(specs): rankingInfo required properties #3157

merged 1 commit into from
Jun 11, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 11, 2024

🧭 What and Why

According to the doc examples, promoted, words and filters are not required on the rankingInfo response, and it's blocking on the dart client: algolia/algoliasearch-client-dart#6

@millotp millotp self-assigned this Jun 11, 2024
@millotp millotp requested a review from a team as a code owner June 11, 2024 08:15
@millotp millotp requested review from morganleroi and Fluf22 June 11, 2024 08:15
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 11, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link

@github-actions github-actions bot temporarily deployed to pull request June 11, 2024 08:27 Inactive
@millotp millotp merged commit c251dc8 into main Jun 11, 2024
25 checks passed
@millotp millotp deleted the fix/rankingInfo branch June 11, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants