fix(clients): safer replaceAllObjects + metis compliant #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
reviewed
Jun 11, 2024
|
|
||
| Always wait on the destination index, because: | ||
| - it's the only index that we know for sure will exist (since we create it). | ||
| - it is Metis compliant, no need for custom implementation. |
There was a problem hiding this comment.
is this something we want to expose in a public documentation ? this seems like internal details
There was a problem hiding this comment.
I think it's fine, pretty niche documentation, I can ask
millotp
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2407
Changes included:
Add metis compliant implementation for
replaceAllObjects, also ensure it never hangs if the source index does not exist, detailed explanation in the docs.suggested implementation from @Jerska