Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): add generate_secured_api_key to ruby #3166

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 12, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-1777

Add generate_secured_api_key and get_secured_api_key_remaining_validity for ruby

@millotp millotp self-assigned this Jun 12, 2024
@millotp millotp requested a review from a team as a code owner June 12, 2024 08:28
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 12, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link

github-actions bot commented Jun 12, 2024

@github-actions github-actions bot temporarily deployed to pull request June 12, 2024 08:42 Inactive
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some base tests like

def test_generate_secured_api_key_0(self):
?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it in #2798 actually with generated tests ! but only 4/11 lang are ready so I can't merge this PR yet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah oki I didn't thought you would continue it before ga

@github-actions github-actions bot temporarily deployed to pull request June 12, 2024 12:01 Inactive
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@millotp millotp enabled auto-merge (squash) June 12, 2024 15:27
@github-actions github-actions bot temporarily deployed to pull request June 12, 2024 15:38 Inactive
@millotp millotp merged commit b2a464a into main Jun 12, 2024
13 checks passed
@millotp millotp deleted the feat/ruby-api-key branch June 12, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants