Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): clarify decompounding limitations #3227

Merged
merged 3 commits into from
Jul 30, 2024
Merged

fix(specs): clarify decompounding limitations #3227

merged 3 commits into from
Jul 30, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Jun 21, 2024 •
edited
Loading

🧭 What and Why

There was a recent clarification in the old docs to the decompoundQuery and decompoundedAttributes parameters, that they don't work with some Unicode characters.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 21, 2024 •
edited
Loading

🚀 Deployed on https://66a88ddffdcd54fb189bf9a4--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 21, 2024 16:26 Inactive
@kai687 kai687 marked this pull request as ready for review July 30, 2024 06:17
@kai687 kai687 requested a review from a team as a code owner July 30, 2024 06:17
@kai687 kai687 requested review from Fluf22 and millotp July 30, 2024 06:17
@kai687
Copy link
Contributor Author

kai687 commented Jul 30, 2024

Forgot about this PR.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 30, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by c9a1550791033e462260f1b73b5779abde6d0b94
🍃 Generated commit dea177ab987e203a2fdc92fa7204b6defe4697fb
🌲 Generated branch generated/fix/specs/decompounding
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
php 1383
javascript 1331
csharp 973
java 946
ruby 874
swift 735
python 720
kotlin 492
go 457

@algolia algolia deleted a comment from algolia-bot Jul 30, 2024
millotp
millotp approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@millotp millotp merged commit a35e814 into main Jul 30, 2024
21 checks passed
@millotp millotp deleted the fix/specs/decompounding branch July 30, 2024 07:01
algolia-bot added a commit that referenced this pull request Jul 30, 2024
@algolia-bot @kai687
fix(specs): clarify decompounding limitations (#3227) (generated) [sk…
6904962 
…ip ci]

Co-authored-by: Kai Welke <kai.welke@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kai687 @algolia-bot @millotp