fix(javascript): update template to include correct dependency version #328
Conversation
❌ Deploy Preview for api-clients-automation failed.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
eunjae-lee
requested review from
a team,
damcou and
shortcuts
and removed request for
a team
| @@ -31,7 +32,10 @@ export const GENERATORS: Record<string, Generator> = { | |||
| key: 'javascript-algoliasearch', | |||
| additionalProperties: { | |||
| packageName: '@experimental-api-clients-automation/algoliasearch', | |||
| packageVersion: '0.0.5', | |||
| packageVersion: | |||
There was a problem hiding this comment.
We pull the version from the main package (in case of js, it's client-search).
There was a problem hiding this comment.
We could also import it from algoliasearch's package.json file directly, wdyt?
There was a problem hiding this comment.
Then we need to assume openapitools.json and package.json files are always in sync at any point of time. But I'm not sure if we can make such an assumption. It's easier to maintain if we take openapitools.json as a single and only source of truth. What do you think?
There was a problem hiding this comment.
package.json depends on openapitools.json, so we know that the package.json will be up to date when changes happen in the main file, but once we remove clients from main we won't have this package.json actually so let's go with your solution
algolia/api-clients-automation#328 Co-authored-by: Eunjae Lee <karis612@gmail.com>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-407
Changes included: