Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add redirect to renderingContent #3296

Merged
merged 8 commits into from
Jul 1, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2541

Changes included:

Add the redirect property to the rendering content field, referenced from https://github.com/algolia/algoliasearch-client-go/blob/64232385c99915e8dc51daa1fa4c753c2ab7e97a/algolia/search/rendering_content.go#L5, solves a customer request

@shortcuts shortcuts self-assigned this Jul 1, 2024
@shortcuts shortcuts requested a review from a team as a code owner July 1, 2024 10:13
@shortcuts shortcuts requested review from morganleroi and millotp July 1, 2024 10:13
@shortcuts shortcuts enabled auto-merge (squash) July 1, 2024 11:36
Copy link

github-actions bot commented Jul 1, 2024

@algolia algolia deleted a comment from algolia-bot Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

✔️ Code generated!

Name Link
🔨 Triggered by 3f9138717cfdc39df0988463ed38edcb2a920cda
🌲 Generated branch generated/feat/redirect-rendering-content

@morganleroi
Copy link
Contributor

WDYT about adding a custom comment for the Redirect property in SearchResponse that seems to be an internal property ?

@shortcuts
Copy link
Member Author

WDYT about adding a custom comment for the Redirect property in SearchResponse that seems to be an internal property ?

good point, done!

Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@shortcuts shortcuts merged commit 9776cb3 into main Jul 1, 2024
19 checks passed
@shortcuts shortcuts deleted the feat/redirect-rendering-content branch July 1, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants