-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): add /schedule endpoint #3350
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Hey, for that new endpoint, you need to add a test file (see docs) here https://github.com/algolia/api-clients-automation/tree/main/tests/CTS/requests/abtesting with the name of the operation |
f9619b0
to
8a19933
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks really good thanks for the contribution !
Hey @febeck, is this ready to be merged or is the API not ready yet ? |
Hey @millotp this is not yet to be merged as there is still some work to be done around this endpoint. It will probably stay here in draft for still a couple of weeks at least. Don't worry about rebasing or checking on this. I'll put at is as "ready for review" when it's actually ready to be merged. I am sorry if this has disturbed your workflow, I should have noted it when opening the PR |
d2c0765
to
473ffe8
Compare
@millotp and @shortcuts this is finally ready to be merged. I have CI failing but I don't really get what the issue is. Could one of you help me with that, please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small question, looks good otherwise !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect !
Hey, this feature will be available in the next minor of the API clients, later today :) |
Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia/api-clients-automation#3350 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia/api-clients-automation#3350 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia/api-clients-automation#3350 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia/api-clients-automation#3350 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia/api-clients-automation#3350 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia/api-clients-automation#3350 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia/api-clients-automation#3350 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia/api-clients-automation#3350 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia/api-clients-automation#3350 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia/api-clients-automation#3350 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
🧭 What and Why
Add documentation for newly added
/schedule
endpoint🎟 JIRA Ticket: OPTIM-1160
Changes included:
scheduledAt
🧪 Test
Added new test file with sample