Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add v2 endpoints for ingestion #3410

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2612

Changes included:

add v2 endpoints for tasks on the ingestion API, mark all v1 as deprecated

@shortcuts shortcuts self-assigned this Jul 23, 2024
@shortcuts shortcuts requested a review from a team as a code owner July 23, 2024 13:15
@shortcuts shortcuts requested review from morganleroi and Fluf22 July 23, 2024 13:15
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 23, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 57c0abb05e0c6b9afa22f624230b547facab03f1
🍃 Generated commit 12a8799c4f22d3303788b18f74fc7e13ef48774f
🌲 Generated branch generated/feat/ingestion-tasks-v2
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1418
php 1364
csharp 1076
java 949
ruby 902
python 745
swift 738
kotlin 480
go 459

@shortcuts shortcuts force-pushed the feat/ingestion-tasks-v2 branch from 3820402 to a0ca699 Compare July 23, 2024 13:15
@shortcuts shortcuts changed the title Feat/ingestion tasks v2 feat(specs): add v2 endpoints for ingestion Jul 23, 2024
TaskV1:
type: object
additionalProperties: false
deprecated: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can add all the deprecated in a second time, lets give some time for people to upgrade without having warnings all over the place 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it only warns in python, our usage is in JS so I guess that's fine to properly tag the fields

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are depreciation warning in scala and swift also

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have to worry about those, the client is still in beta and our consumers rely on typescript so we should be fine

@shortcuts
Copy link
Member Author

everything seems good, we can wait for the new endpoints to be on prod to merge this one

@shortcuts shortcuts marked this pull request as draft July 23, 2024 13:54
@shortcuts shortcuts marked this pull request as ready for review July 24, 2024 08:07
Copy link

github-actions bot commented Jul 24, 2024

@shortcuts shortcuts requested a review from millotp July 24, 2024 09:38
@shortcuts shortcuts enabled auto-merge (squash) July 24, 2024 09:38
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@shortcuts shortcuts disabled auto-merge July 24, 2024 11:16
@shortcuts shortcuts enabled auto-merge (squash) July 24, 2024 11:29
@shortcuts shortcuts merged commit fe6f5ed into main Jul 24, 2024
20 checks passed
@shortcuts shortcuts deleted the feat/ingestion-tasks-v2 branch July 24, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants