-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): add v2 endpoints for ingestion #3410
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
3820402
to
a0ca699
Compare
TaskV1: | ||
type: object | ||
additionalProperties: false | ||
deprecated: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can add all the deprecated in a second time, lets give some time for people to upgrade without having warnings all over the place 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it only warns in python, our usage is in JS so I guess that's fine to properly tag the fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are depreciation warning in scala and swift also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have to worry about those, the client is still in beta and our consumers rely on typescript so we should be fine
everything seems good, we can wait for the new endpoints to be on prod to merge this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2612
Changes included:
add v2 endpoints for tasks on the ingestion API, mark all v1 as deprecated