Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): add primary to get settings response #3415

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Jul 24, 2024

🧭 What and Why

When retrieving the settings for a replica index, the API response includes a primary field.

🎟 JIRA Ticket:

Changes included:

  • Modify the response to the get settings operation

🧪 Test

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 24, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 7cfda97fc31dcb46d714f3fa40a0f473a8fe11c6
🍃 Generated commit ddc71bb522ffc24460a1728038938fe20db3496e
🌲 Generated branch generated/fix/primary
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1367
php 1265
csharp 1117
java 886
ruby 862
swift 750
python 721
kotlin 478
go 446

Copy link

github-actions bot commented Jul 24, 2024

@kai687 kai687 marked this pull request as ready for review July 24, 2024 20:04
@kai687 kai687 requested a review from a team as a code owner July 24, 2024 20:04
@kai687 kai687 requested review from millotp and shortcuts July 24, 2024 20:04
@shortcuts shortcuts merged commit 200f07e into main Jul 25, 2024
21 checks passed
@shortcuts shortcuts deleted the fix/primary branch July 25, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants