fix(java): apply Mouaad suggestions APIC-396 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
requested review from
eunjae-lee and
shortcuts
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
reviewed
Apr 7, 2022
Comment on lines
239
to
242
| return value | ||
| .replaceAll("\\W+", "_") | ||
| .replaceAll("(\\b[a-z]+|\\G(?!^))((?:[A-Z]|\\d+)[a-z]*)", "$1_$2") | ||
| .toUpperCase(Locale.ROOT); |
There was a problem hiding this comment.
Suggested change
| return value | |
| .replaceAll("\\W+", "_") | |
| .replaceAll("(\\b[a-z]+|\\G(?!^))((?:[A-Z]|\\d+)[a-z]*)", "$1_$2") | |
| .toUpperCase(Locale.ROOT); | |
| return value | |
| .replaceAll("(.+?)([A-Z]|[0-9])", "$1_$2") | |
| .toUpperCase(Locale.ROOT); |
Not fully tested but I think it should work
There was a problem hiding this comment.
Your regex works even better, it handles the case like AddUnique -> ADD_UNIQUE that didn't work before, thanks !
shortcuts
approved these changes
Apr 7, 2022
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Apr 7, 2022
algolia/api-clients-automation#344 Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
This was referenced Apr 11, 2022
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-396
Apply the suggestions brought by @aallam in this PR
Changes included:
java.util.Datefinalkeyword when needed🧪 Test
CI