Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): proper title with linter #3444

Merged
merged 9 commits into from
Jul 30, 2024
Merged

fix(specs): proper title with linter #3444

merged 9 commits into from
Jul 30, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 29, 2024

🧭 What and Why

The title are use by openapi generator to create the name of the model, they need to be set when the model is inlined in the spec, and with some consistency to make them usable in the scripts.

@millotp millotp requested a review from a team as a code owner July 29, 2024 15:03
@millotp millotp self-assigned this Jul 29, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 29, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 6d76b40ec4781f4f91c5d24846554361e479c2bd
🍃 Generated commit e5e6d4015fb29f758311bbbbc04ab06e5aca0ac1
🌲 Generated branch generated/fix/title
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
php 1402
javascript 1353
csharp 1156
java 912
ruby 868
swift 745
python 706
kotlin 469
go 462

Copy link

github-actions bot commented Jul 29, 2024

Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who ! Indeed it's better now !

@millotp millotp enabled auto-merge (squash) July 30, 2024 08:13
@millotp millotp merged commit e179701 into main Jul 30, 2024
21 checks passed
@millotp millotp deleted the fix/title branch July 30, 2024 08:24
algolia-bot added a commit that referenced this pull request Jul 30, 2024
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3444

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3444

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3444

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3444

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3444

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3444

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3444

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3444

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3444

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3444

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3444

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants