Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): delete unused models #3445

Merged
merged 9 commits into from
Jul 30, 2024
Merged

feat(clients): delete unused models #3445

merged 9 commits into from
Jul 30, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 29, 2024

🧭 What and Why

🎟 JIRA Ticket: APIC-719

Explore the graph of all models and operations to prune the unused models, which are most likely used in allOf but not generated because openapi prefers to put all the props in the allOf directly.

@millotp millotp self-assigned this Jul 29, 2024
@millotp millotp requested a review from a team as a code owner July 29, 2024 17:09
@millotp millotp requested review from morganleroi and Fluf22 and removed request for a team July 29, 2024 17:09
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 29, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 6b41548a3ff5901cf191edc714150f7a6ad9cdb4
🍃 Generated commit 49fadd4e190f75ea8bcab31c412aea09ae2da72c
🌲 Generated branch generated/feat/remove-dup-models
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
php 1369
javascript 1366
csharp 1033
java 904
ruby 862
swift 736
python 735
kotlin 484
go 447

@millotp millotp force-pushed the feat/remove-dup-models branch from 30d814a to ae3d35d Compare July 29, 2024 20:24
Base automatically changed from fix/title to main July 30, 2024 08:24
@millotp millotp force-pushed the feat/remove-dup-models branch from cad0762 to bb90732 Compare July 30, 2024 08:58
Copy link

github-actions bot commented Jul 30, 2024

Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insane diff. Insane work !

@millotp millotp merged commit 41d86ce into main Jul 30, 2024
21 checks passed
@millotp millotp deleted the feat/remove-dup-models branch July 30, 2024 11:54
algolia-bot added a commit that referenced this pull request Jul 30, 2024
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jul 30, 2024
algolia/api-clients-automation#3445

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants