Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): remove mention of GA #3452

Merged
merged 4 commits into from
Aug 1, 2024
Merged

chore(clients): remove mention of GA #3452

merged 4 commits into from
Aug 1, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Aug 1, 2024

🧭 What and Why

This statement is not true and is causing confusing internally, we can add it back later when we have more info on the true release state

@millotp millotp requested a review from a team as a code owner August 1, 2024 09:35
@millotp millotp self-assigned this Aug 1, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 1, 2024

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
csharp 1083
java 912

@millotp millotp changed the title chore(javascript): remove mention of v5 chore(clients): remove mention of GA Aug 1, 2024
Fluf22
Fluf22 previously approved these changes Aug 1, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others have it too no? IIRC i made it the same for every clients

Copy link

github-actions bot commented Aug 1, 2024

@millotp
Copy link
Collaborator Author

millotp commented Aug 1, 2024

I looked in the other readme and those are the only 3 to have the mention of July

@millotp millotp merged commit 27679b7 into main Aug 1, 2024
13 checks passed
@millotp millotp deleted the chore/remove-release branch August 1, 2024 11:29
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 1, 2024
algolia/api-clients-automation#3452

Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 1, 2024
algolia/api-clients-automation#3452

Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 1, 2024
algolia/api-clients-automation#3452

Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants