Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): move the license to the root #3457

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Aug 3, 2024

🧭 What and Why

For most languages, the LICENSE should be at the root, this is preventing the go doc from being generated for example:

Screenshot 2024-08-03 at 08 59 45

@millotp millotp self-assigned this Aug 3, 2024
@millotp millotp requested a review from a team as a code owner August 3, 2024 07:04
@millotp millotp requested review from morganleroi and Fluf22 August 3, 2024 07:04
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 3, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 50a489e4733a8cdba31a5840402b0addeba6f066
🍃 Generated commit 0578c8b793024c91ebdb6a51f5ef8a830710769b
🌲 Generated branch generated/fix/license-root
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1351
php 1345
csharp 1026
java 925
ruby 905
python 727
swift 724
kotlin 469
go 454

Copy link

github-actions bot commented Aug 3, 2024

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@shortcuts shortcuts enabled auto-merge (squash) August 5, 2024 12:06
@shortcuts shortcuts merged commit b4742be into main Aug 5, 2024
21 checks passed
@shortcuts shortcuts deleted the fix/license-root branch August 5, 2024 12:21
algolia-bot added a commit that referenced this pull request Aug 5, 2024
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3457

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3457

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 5, 2024
algolia/api-clients-automation#3457

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants