Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): partial update operation #3486

Merged
merged 31 commits into from
Aug 28, 2024
Merged

fix(specs): partial update operation #3486

merged 31 commits into from
Aug 28, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Aug 7, 2024 •
edited by shortcuts
Loading

🧭 What and Why

close algolia/algoliasearch-client-javascript#1542
https://algolia.atlassian.net/browse/DI-2830

The partial update object operation accepts either a built-in operation or a new value for an attribute, which can be any type. Currently, only "built-in operation" and "string" are accepted.

Changes included:

  • Update the attributeToUpdate oneOf to accept any type in addition to the builtInOperation model.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 7, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by a04a2542f4b6c1b40da101e3a145b8bbaab652b2
🍃 Generated commit 9e82f9123b4adc2643d07f1aac88315fff86715a
🌲 Generated branch generated/fix/partial-update
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1709
php 1506
csharp 1117
java 947
ruby 926
swift 777
python 733
go 570
kotlin 500

@kai687
Copy link
Contributor Author

kai687 commented Aug 7, 2024

hmmm, maybe it'll be difficult to discriminate between model types for the code generation.

@kai687 kai687 marked this pull request as ready for review August 14, 2024 12:12
@kai687 kai687 requested a review from a team as a code owner August 14, 2024 12:12
@kai687
Copy link
Contributor Author

kai687 commented Aug 26, 2024

This affects a user now in algolia/algoliasearch-client-javascript#1542

shortcuts
shortcuts previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

splendid

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

🚀 Deployed on https://66cef2ec0e83312a18eab190--api-clients-automation.netlify.app

shortcuts
shortcuts approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@millotp millotp merged commit 41f849e into main Aug 28, 2024
21 checks passed
@millotp millotp deleted the fix/partial-update branch August 28, 2024 10:02
algolia-bot added a commit that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (#3486) (generated) [skip ci]
be827f4 
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (generated)
475a404 
algolia/api-clients-automation#3486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (generated)
ca24cfd 
algolia/api-clients-automation#3486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (generated)
9992315 
algolia/api-clients-automation#3486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (generated)
ec85e7b 
algolia/api-clients-automation#3486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (generated)
bbdbf75 
algolia/api-clients-automation#3486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (generated)
69fe082 
algolia/api-clients-automation#3486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (generated)
be81183 
algolia/api-clients-automation#3486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (generated)
accd712 
algolia/api-clients-automation#3486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (generated)
c006d8f 
algolia/api-clients-automation#3486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (generated)
50f2e6a 
algolia/api-clients-automation#3486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Aug 28, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): partial update operation (generated)
09b7da8 
algolia/api-clients-automation#3486

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@kai687 kai687

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

partialUpdateObject in v5 client does not allow array values
4 participants
@kai687 @algolia-bot @shortcuts @millotp