Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(specs): update api's length minimum value #3574

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

Jerska
Copy link
Member

@Jerska Jerska commented Aug 22, 2024

🧭 What and Why

GH PR: https://github.com/algolia/AlgoliaSaaS/pull/11547

Changes included:

Change the length minimum from 1 to 0.

@Jerska Jerska self-assigned this Aug 22, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 22, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 68b2ae27eb54bf64695eaf9b163dd4617f4d4ec3
🍃 Generated commit 5692dda25aa20e9c508fe41396fbbebea19b9db3
🌲 Generated branch generated/feat/update-length
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1345
php 1336
csharp 1119
ruby 888
java 886
swift 751
python 721
go 539
kotlin 472

@Jerska
Copy link
Member Author

Jerska commented Aug 22, 2024

Note: I tried committing what apic build specs -d changed but a git hook prevented me from doing so.
I guess those will be autocommitted afterwards?

@Jerska Jerska changed the title feat(api): update length minimum value feat(specs): update api's length minimum value Aug 22, 2024
@Jerska Jerska changed the title feat(specs): update api's length minimum value docs(specs): update api's length minimum value Aug 22, 2024
@Jerska Jerska marked this pull request as ready for review August 22, 2024 12:39
@Jerska Jerska requested a review from a team as a code owner August 22, 2024 12:39
@millotp
Copy link
Collaborator

millotp commented Aug 22, 2024

@algolia-bot will push all the generated code into a new branch at the end of the CI yes :)
thanks for the contribution !

Copy link

@millotp millotp merged commit 9b6dc0b into main Aug 22, 2024
21 checks passed
@millotp millotp deleted the feat/update-length branch August 22, 2024 12:55
algolia-bot added a commit that referenced this pull request Aug 22, 2024
…kip ci]

Co-authored-by: Matthieu Dumont <5095856+Jerska@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Aug 22, 2024
algolia/api-clients-automation#3574

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Matthieu Dumont <5095856+Jerska@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 22, 2024
algolia/api-clients-automation#3574

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Matthieu Dumont <5095856+Jerska@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Aug 22, 2024
algolia/api-clients-automation#3574

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Matthieu Dumont <5095856+Jerska@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 22, 2024
algolia/api-clients-automation#3574

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Matthieu Dumont <5095856+Jerska@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Aug 22, 2024
algolia/api-clients-automation#3574

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Matthieu Dumont <5095856+Jerska@users.noreply.github.com>
@Jerska
Copy link
Member Author

Jerska commented Aug 22, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants