feat(specs): add analytics specs and client.
#36
Conversation
| content: | ||
| application/json: | ||
| schema: | ||
| oneOf: |
There was a problem hiding this comment.
Is there a way to transform this with polymorphism or optional properties ?
There was a problem hiding this comment.
The issue is that it wouldn't represent the API... but indeed for Java (😢) we could have a fully optional type
specs/common/parameters.yml
Outdated
| EndDate: | ||
| in: query | ||
| name: endDate | ||
| description: The upper bound timestamp (a date, a string like “2006-01-02”) of the period to analyze |
There was a problem hiding this comment.
Don't you need a dot here ? The linter didn't catch that ?
There was a problem hiding this comment.
yamllint did not catch it and I think eslint automatically applied a dot on the output. I wonder if we could add a spec rule, I'll check!
| return ( | ||
| isTimedOut || | ||
| isNetworkError({ isTimedOut, status }) || | ||
| (~~(status / 100) !== 2 && ~~(status / 100) !== 4) |
There was a problem hiding this comment.
Oof, I'm sure it was copied from nuno but are we fine those ~~ I honestly don't know what they mean ahah
There was a problem hiding this comment.
Exactly, It seems like an overcomplicated way to have the absolute value of status
There was a problem hiding this comment.
At least 4 people said this ahah I think we can remove them they are more confusing than anything
There was a problem hiding this comment.
Yep, will do a second PR right after
clients/algoliasearch-client-javascript/client-analytics/utils/requester/HttpRequester.ts
Show resolved
Hide resolved
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
analyticsspecs and clientmax-paramsin eslint configeslintcommand on fail (see comment)🧪 Test
CI :D