Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): ingestion push task payload [skip-bc] #3607

Merged
merged 14 commits into from
Aug 29, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

use the new push task payload signature

@shortcuts shortcuts self-assigned this Aug 28, 2024
@shortcuts shortcuts requested a review from a team as a code owner August 28, 2024 13:57
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 28, 2024

✔️ Code generated!

Name Link
🪓 Triggered by c5883513b6ab1c76bca007d9fd0c0743e9088c36
🍃 Generated commit 116466736ba61953c278c1557d3f72db209845a0
🌲 Generated branch generated/fix/push-specs-ingestion
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1582
php 1455
csharp 1018
java 942
ruby 909
swift 769
python 744
go 554
kotlin 470

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for the gen since there is a generic

@@ -15,7 +15,23 @@ post:
content:
application/json:
schema:
$ref: '../../../../common/schemas/Batch.yml#/batchWriteParams'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is no longer common if you remove it here, but its not very important

@shortcuts shortcuts changed the title fix(specs): ingestion push task payload fix(specs): ingestion push task payload [skip-bc] Aug 29, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice

@shortcuts
Copy link
Member Author

huge thanks again ❤️ @millotp

@shortcuts shortcuts enabled auto-merge (squash) August 29, 2024 13:47
Copy link

@shortcuts shortcuts merged commit 327e08d into main Aug 29, 2024
20 checks passed
@shortcuts shortcuts deleted the fix/push-specs-ingestion branch August 29, 2024 13:51
algolia-bot added a commit that referenced this pull request Aug 29, 2024
… [skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3607

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3607

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3607

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3607

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3607

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3607

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3607

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3607

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3607

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3607

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants