-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(specs): don't extend $ref objects #3623
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove the product clicked example of the eventName ref then? This should avoid confusion
@shortcuts PR 3619 removed the |
Ah indeed bah nice, cc @JonathanMontane just fyi |
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Even better then! |
🧭 What and Why
PR #3619 added
eventName
examples for different event objects in the Insights API, instead of using "Product clicked" for all events.But, extending/overriding the
example
property isn't supported by the OpenAPI spec, and is ignored when rendering the docs. (tested locally with the redocly CLI).This PR removes the examples. We provide full examples for each event in the right column, so an extra example property of the event name isn't really necessary anyway.
If I understand the specs correctly:
summary
anddescription
properties of the referenced object, but still notexample
.OpenAPI 3.1.0
OpenAPI 3.0.3
🎟 JIRA Ticket:
Changes included:
eventName
examples