Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): usage api #3624

Merged
merged 5 commits into from
Sep 2, 2024
Merged

fix(specs): usage api #3624

merged 5 commits into from
Sep 2, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Aug 30, 2024

🧭 What and Why

Improve the Usage API spec.

🎟 JIRA Ticket: DOC-1499

Changes included:

  • Remove (internal) usage-dev server from the spec
  • Add usage tag to each method (tag was defined in the spec, but not added to the methods)
  • Start date and end date must be full RFC 3339 dates

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 30, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 4c02b3265d93e7a2d883e4526359a15f08128e32
🍃 Generated commit 1dc3589ae5f2d11f70c6ebeb76a322ffdc0b9bd0
🌲 Generated branch generated/fix/specs/usage
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1680
php 1477
csharp 1173
python 982
java 941
ruby 936
swift 779
go 573
kotlin 512

@kai687 kai687 marked this pull request as ready for review August 30, 2024 12:48
@kai687 kai687 requested a review from a team as a code owner August 30, 2024 12:48
shortcuts
shortcuts previously approved these changes Aug 30, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@shortcuts
Copy link
Member

ci will be green after #3622

Copy link

github-actions bot commented Sep 2, 2024

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg!

@shortcuts shortcuts merged commit a9405b1 into main Sep 2, 2024
25 checks passed
@shortcuts shortcuts deleted the fix/specs/usage branch September 2, 2024 17:46
algolia-bot added a commit that referenced this pull request Sep 2, 2024
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Sep 2, 2024
algolia/api-clients-automation#3624

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Sep 2, 2024
algolia/api-clients-automation#3624

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Sep 2, 2024
algolia/api-clients-automation#3624

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Sep 2, 2024
algolia/api-clients-automation#3624

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 2, 2024
algolia/api-clients-automation#3624

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Sep 2, 2024
algolia/api-clients-automation#3624

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Sep 2, 2024
algolia/api-clients-automation#3624

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Sep 2, 2024
algolia/api-clients-automation#3624

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Sep 2, 2024
algolia/api-clients-automation#3624

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Sep 2, 2024
algolia/api-clients-automation#3624

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Sep 2, 2024
algolia/api-clients-automation#3624

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants