Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clients): add helper to check if an index exists #3646

Merged
merged 16 commits into from
Sep 4, 2024
Merged

feat(clients): add helper to check if an index exists #3646

merged 16 commits into from
Sep 4, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Sep 3, 2024 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-2775. closes algolia/algoliasearch-client-php#732

Add the indexExists helpers which uses getSettings behind the hood.

@millotp millotp self-assigned this Sep 3, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 3, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by f2bb894757c64b7269c69ddd1d684438d0612d39
🍃 Generated commit 4ce3ad8f4649e1bc25ad27763aab37841324f7ae
🌲 Generated branch generated/feat/index-exists
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1666
php 1557
csharp 1172
python 1017
ruby 914
java 892
swift 781
go 552

@millotp millotp marked this pull request as ready for review September 3, 2024 19:15
@millotp millotp requested a review from a team as a code owner September 3, 2024 19:15
shortcuts
shortcuts reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! waiting for the gen

ggggg

scripts/cli/index.ts Show resolved Hide resolved
tests/output/python/pyproject.toml Show resolved Hide resolved
millotp and others added 2 commits September 3, 2024 22:53
@millotp
kotlin null
57c67af
@Fluf22
fix(swift): rethrow correct error type for future catch
487b214 
Fixes multiple issues in the search client extensions:
- the initial issue which was that when rethrowing an error, we would do
so with the underlying error instead of wrapping it back in the original
type
- a side issue where we were trying on a non-throwing built string
(relicate from a past method call at the same place)
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

🚀 Deployed on https://66d82f4def8b8778ad78bdae--api-clients-automation.netlify.app

@millotp millotp enabled auto-merge (squash) September 4, 2024 09:46
shortcuts
shortcuts approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks so puuurfect

@millotp millotp merged commit 3d02b31 into main Sep 4, 2024
25 checks passed
@millotp millotp deleted the feat/index-exists branch September 4, 2024 10:10
algolia-bot added a commit that referenced this pull request Sep 4, 2024
@algolia-bot @millotp @Fluf22
feat(clients): add helper to check if an index exists (#3646) (genera…
c883383 
…ted) [skip ci]

Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Sep 4, 2024
@algolia-bot @millotp @Fluf22
feat(clients): add helper to check if an index exists (generated)
5049bd0 
algolia/api-clients-automation#3646

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Sep 4, 2024
@algolia-bot @millotp @Fluf22
feat(clients): add helper to check if an index exists (generated)
7853c8c 
algolia/api-clients-automation#3646

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Sep 4, 2024
@algolia-bot @millotp @Fluf22
feat(clients): add helper to check if an index exists (generated)
aa8b824 
algolia/api-clients-automation#3646

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 4, 2024
@algolia-bot @millotp @Fluf22
feat(clients): add helper to check if an index exists (generated)
263c7ee 
algolia/api-clients-automation#3646

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Sep 4, 2024
@algolia-bot @millotp @Fluf22
feat(clients): add helper to check if an index exists (generated)
a5da61e 
algolia/api-clients-automation#3646

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Sep 4, 2024
@algolia-bot @millotp @Fluf22
feat(clients): add helper to check if an index exists (generated)
b259180 
algolia/api-clients-automation#3646

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Sep 4, 2024
@algolia-bot @millotp @Fluf22
feat(clients): add helper to check if an index exists (generated)
f6351a3 
algolia/api-clients-automation#3646

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Sep 4, 2024
@algolia-bot @millotp @Fluf22
feat(clients): add helper to check if an index exists (generated)
f7f345a 
algolia/api-clients-automation#3646

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Sep 4, 2024
@algolia-bot @millotp @Fluf22
feat(clients): add helper to check if an index exists (generated)
509f56d 
algolia/api-clients-automation#3646

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Sep 4, 2024
@algolia-bot @millotp @Fluf22
feat(clients): add helper to check if an index exists (generated)
795bf75 
algolia/api-clients-automation#3646

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V4 how to check existings of a Index
4 participants
@millotp @algolia-bot @shortcuts @Fluf22