Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add (optional) _automaticInsights to search result #3688

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

raed667
Copy link
Contributor

@raed667 raed667 commented Sep 11, 2024

🧭 What and Why

Return the parameter _automaticInsights (when possible) when calling search.

Why

I need this value in the Recommend mono-repository so that the Recommend API can forward this parameter to the Recommend client.

@raed667 raed667 requested a review from a team as a code owner September 11, 2024 08:32
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 11, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 64059b877849ff05b313cb8b738272e20f912b19
🍃 Generated commit ccf7df497b18890ef1093a9158e2243c3b942f50
🌲 Generated branch generated/feat-add-automatic-insights
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1697
php 1550
csharp 1231
python 1003
java 952
ruby 917
swift 760
go 569

@raed667 raed667 changed the title add (optional) _automaticInsights to search result feat(specs): add (optional) _automaticInsights to search result Sep 11, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@millotp millotp merged commit 46d9d8f into main Sep 11, 2024
29 checks passed
@millotp millotp deleted the feat-add-automatic-insights branch September 11, 2024 09:11
algolia-bot added a commit that referenced this pull request Sep 11, 2024
… (generated) [skip ci]

Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Sep 11, 2024
…rated)

algolia/api-clients-automation#3688

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Sep 11, 2024
…rated)

algolia/api-clients-automation#3688

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Sep 11, 2024
…rated)

algolia/api-clients-automation#3688

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Sep 11, 2024
…rated)

algolia/api-clients-automation#3688

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 11, 2024
…rated)

algolia/api-clients-automation#3688

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Sep 11, 2024
…rated)

algolia/api-clients-automation#3688

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Sep 11, 2024
…rated)

algolia/api-clients-automation#3688

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Sep 11, 2024
…rated)

algolia/api-clients-automation#3688

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Sep 11, 2024
…rated)

algolia/api-clients-automation#3688

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Sep 11, 2024
…rated)

algolia/api-clients-automation#3688

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Sep 11, 2024
…rated)

algolia/api-clients-automation#3688

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
millotp pushed a commit to algolia/algoliasearch-client-go that referenced this pull request Sep 23, 2024
## 🧭 What and Why

Porting this PR to v3 :
algolia/api-clients-automation#3688

Return the parameter `_automaticInsights` (when possible) when calling
search.


# Why 

I need this value in the Recommend mono-repository so that the Recommend
API can forward this parameter to the Recommend client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants