Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): remove usage [skip-bc] #3691

Merged
merged 9 commits into from
Sep 11, 2024
Merged

fix(specs): remove usage [skip-bc] #3691

merged 9 commits into from
Sep 11, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Sep 11, 2024

🧭 What and Why

Adding a tag group to the Usage API spec, so that the custom POST/PUT/DEL requests won't show up in the API reference.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 11, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by a20941f2fd8470ad4325201877d8193abbee7947
🍃 Generated commit 9dbe08de1bba9241c684a8f780339c6673424321
🌲 Generated branch generated/fix/hide-custom
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1631
php 1506
csharp 1078
python 993
java 972
ruby 888
swift 775
go 566

@kai687 kai687 marked this pull request as ready for review September 11, 2024 13:16
@kai687 kai687 requested a review from a team as a code owner September 11, 2024 13:16
shortcuts
shortcuts previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

🚀 Deployed on https://66e1ab91ba2baa07283fa905--api-clients-automation.netlify.app

@millotp millotp changed the title fix(specs): tag group for usage api fix(specs): remove usage Sep 11, 2024
@millotp millotp changed the title fix(specs): remove usage fix(specs): remove usage [skip-bc] Sep 11, 2024
millotp
millotp approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so much cleaner

@shortcuts shortcuts enabled auto-merge (squash) September 11, 2024 14:39
@shortcuts shortcuts merged commit d4df544 into main Sep 11, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/hide-custom branch September 11, 2024 14:41
algolia-bot added a commit that referenced this pull request Sep 11, 2024
@algolia-bot @kai687
@shortcuts @millotp
fix(specs): remove usage [skip-bc] (#3691) (generated) [skip ci]
223e8b8 
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@millotp millotp millotp approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kai687 @algolia-bot @millotp @shortcuts