Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): recommend remove unsupported query parameters [RECO-2345] [skip-bc] #3692

Merged
merged 13 commits into from
Sep 19, 2024
Merged

fix(specs): recommend remove unsupported query parameters [RECO-2345] [skip-bc] #3692

merged 13 commits into from
Sep 19, 2024

Conversation

raed667
Copy link
Contributor

@raed667 raed667 commented Sep 11, 2024 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/RECO-2345

Changes included:

  • Remove unsupported parameters: page, hitsPerPage, offset, length
  • Comment out unknown parameters until they're supported: customRanking, semanticSearch, mode, keepDiacriticsOnCharacters

🧪 Test

@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 11, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by 2a209c78bd19671b3ba02b4b485db44e72800345
🍃 Generated commit f6423b1b2e71fd8bc432a5bd9667235913a12199
🌲 Generated branch generated/fix-recommend-query-params
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1689
php 1510
python 1017
java 950
csharp 932
ruby 826
swift 754
go 562

@raed667 raed667 changed the title fix(recommend): remove unsupported query parameters fix(specs): recommend remove unsupported query parameters Sep 11, 2024
@millotp
Copy link
Collaborator

millotp commented Sep 12, 2024

hey @raed667, do you need help to make the CI pass ?

@raed667
Copy link
Contributor Author

raed667 commented Sep 12, 2024

@millotp thanks! i'm currently gathering a bit more information about the API, i'll let you once i start updating the PR again

@raed667 raed667 changed the title fix(specs): recommend remove unsupported query parameters fix(specs): recommend remove unsupported query parameters [RECO-2345] Sep 18, 2024
@raed667 raed667 marked this pull request as ready for review September 18, 2024 09:13
@raed667 raed667 requested a review from a team as a code owner September 18, 2024 09:13
@shortcuts shortcuts changed the title fix(specs): recommend remove unsupported query parameters [RECO-2345] fix(specs): recommend remove unsupported query parameters [RECO-2345] [skip-bc] Sep 18, 2024
millotp
millotp approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@shortcuts shortcuts merged commit 1a73994 into main Sep 19, 2024
28 checks passed
@shortcuts shortcuts deleted the fix-recommend-query-params branch September 19, 2024 07:44
algolia-bot added a commit that referenced this pull request Sep 19, 2024
@algolia-bot @raed667
fix(specs): recommend remove unsupported query parameters [RECO-2345]…
e521fc7 
… [skip-bc] (#3692) (generated) [skip ci]

Co-authored-by: Raed <raed.chammam@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raed667 @algolia-bot @millotp @shortcuts