Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): update search api specs [skip-bc] #3760

Merged
merged 2 commits into from
Sep 16, 2024
Merged

fix(specs): update search api specs [skip-bc] #3760

merged 2 commits into from
Sep 16, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Sep 16, 2024 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-2912 & closes #425

Changes included:

  • Makes search response pagination props optional
  • Fixes recursive spec for highlightResult and snippetResult

@Fluf22 Fluf22 self-assigned this Sep 16, 2024
@Fluf22 Fluf22 requested a review from a team as a code owner September 16, 2024 15:11
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 16, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by 82263851402403730650105370faf0b789f98e89
🍃 Generated commit 31b8b37d131016328346b5cf6052903258b117ea
🌲 Generated branch generated/fix/search-response-spec
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1715
php 1501
csharp 1066
python 1044
java 966
ruby 903
swift 758
go 555

@millotp millotp changed the title fix(specs): update search api specs fix(specs): update search api specs [skip-bc] Sep 16, 2024
@Fluf22 Fluf22 requested a review from shortcuts September 16, 2024 16:00
shortcuts
shortcuts approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to have an e2e for that to avoid regression, but great fix!

@Fluf22 Fluf22 merged commit 638058e into main Sep 16, 2024
28 checks passed
@Fluf22 Fluf22 deleted the fix/search-response-spec branch September 16, 2024 17:35
algolia-bot added a commit that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (#3760) (generated) [sk…
9db7daf 
…ip ci]

Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (generated)
915ec10 
algolia/api-clients-automation#3760

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (generated)
a8f8480 
algolia/api-clients-automation#3760

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (generated)
71bd067 
algolia/api-clients-automation#3760

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (generated)
f313a49 
algolia/api-clients-automation#3760

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (generated)
2f7f067 
algolia/api-clients-automation#3760

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (generated)
23f3218 
algolia/api-clients-automation#3760

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (generated)
8f493d1 
algolia/api-clients-automation#3760

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (generated)
2da2b0f 
algolia/api-clients-automation#3760

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (generated)
8523c24 
algolia/api-clients-automation#3760

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (generated)
595ffef 
algolia/api-clients-automation#3760

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Sep 16, 2024
@algolia-bot @Fluf22
fix(specs): update search api specs [skip-bc] (generated)
22be7b8 
algolia/api-clients-automation#3760

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: When using SearchSingleIndex, passing offset & length still requires the key 'page'
3 participants
@Fluf22 @algolia-bot @shortcuts