Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kotlin): deserialization #3822

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Sep 23, 2024

🧭 What and Why

🎟 JIRA Ticket: CR-6916

Changes included:

  • update recommend spec to add oneOf discriminators
  • update template to generate all possible oneOf cases
  • update template to fix array deserialization

🧪 Test

@Fluf22 Fluf22 requested a review from a team as a code owner September 23, 2024 12:59
@Fluf22 Fluf22 self-assigned this Sep 23, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 23, 2024

✔️ Code generated!

Name Link
🪓 Triggered by f5c61bb6337c8c4f4563fb74393a8096a4badcc8
🍃 Generated commit 98340f6b166ce348bb066f8c2b2ad77ad0546efd
🌲 Generated branch generated/fix/kotlin-recommend-discriminators
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1631
go 1578
php 1467
csharp 1275
java 1107
python 1044
ruby 904
swift 752

@Fluf22 Fluf22 force-pushed the fix/kotlin-recommend-discriminators branch from 8e7eb14 to 02d5c38 Compare September 23, 2024 16:42
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok it was broken broken indeed 🤔 we definitely lack e2e then

@shortcuts
Copy link
Member

awesome btw, gg!!

@Fluf22 Fluf22 merged commit 4e82751 into main Sep 23, 2024
28 checks passed
@Fluf22 Fluf22 deleted the fix/kotlin-recommend-discriminators branch September 23, 2024 20:59
algolia-bot added a commit that referenced this pull request Sep 23, 2024
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Sep 23, 2024
algolia/api-clients-automation#3822

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Sep 23, 2024
algolia/api-clients-automation#3822

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Sep 23, 2024
algolia/api-clients-automation#3822

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Sep 23, 2024
algolia/api-clients-automation#3822

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Sep 23, 2024
algolia/api-clients-automation#3822

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Sep 23, 2024
algolia/api-clients-automation#3822

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants