feat(specs): add support for widgets / banners in search for the csharp client #3870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, all the files you edited are generated files, all the files in this folder are generated, can you edit the spec in |
|
Ah, i dident notice that this was all auto generated 😅 Will update my PR in a bit |
|
I updated the PR now, removing the models and updating the schema, however i am struggling with setting up the environment for building this. Followed your guide as outlined here https://api-clients-automation.netlify.app/docs/setup-repository but running into a very ambiguous error with the linter
Any chance you could look over the schema and try to build it to see if i did it correctly? 😇 |
millotp
changed the title
millotp
approved these changes
Oct 4, 2024
|
@millotp Thank you for helping me sort this out! Massive kudos for responding so fast, going to have some thrilled marketers at our company when this is released :) |
algolia-bot
added a commit
that referenced
this pull request
Oct 6, 2024
…rp client (#3870) (generated) [skip ci] Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Oct 6, 2024
…rp client (generated) algolia/api-clients-automation#3870 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Oct 6, 2024
…rp client (generated) algolia/api-clients-automation#3870 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Oct 6, 2024
…rp client (generated) algolia/api-clients-automation#3870 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Oct 6, 2024
…rp client (generated) algolia/api-clients-automation#3870 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Oct 6, 2024
…rp client (generated) algolia/api-clients-automation#3870 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Oct 6, 2024
…rp client (generated) algolia/api-clients-automation#3870 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Oct 6, 2024
…rp client (generated) algolia/api-clients-automation#3870 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Oct 6, 2024
…rp client (generated) algolia/api-clients-automation#3870 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Oct 6, 2024
…rp client (generated) algolia/api-clients-automation#3870 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Oct 6, 2024
…rp client (generated) algolia/api-clients-automation#3870 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Oct 6, 2024
…rp client (generated) algolia/api-clients-automation#3870 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com> Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3869
🧭 What and Why
The csharp client currently does not support Widgets / Banners as part of the RenderingContent model, however this feature is now available in the dashboard / merchandising studio. This PR adds the missing models required for parsing banners from the api response.
Changes included:
Adds the following models:
Also added the missing widgets field to the RenderingContent model