Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): use the read transporter for browse #3938

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 9, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-2966

closes algolia/algoliasearch-client-php#741

The browse method is supposed to use the read transported, as @ivan-wolf as demonstrated here.

@millotp millotp requested a review from a team as a code owner October 9, 2024 22:18
@millotp millotp self-assigned this Oct 9, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 9, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 01496a982c0b98e9065c49d9dbaaf29d4960f23e
🍃 Generated commit 2c4f5cb4777e793f8c49459b2f41295169b5b93c
🌲 Generated branch generated/fix/broswe-read-transporter
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1746
go 1612
php 1477
csharp 1364
java 1164
python 983
ruby 945
swift 741

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@millotp millotp enabled auto-merge (squash) October 9, 2024 23:40
@millotp millotp merged commit 434c99f into main Oct 9, 2024
28 checks passed
@millotp millotp deleted the fix/broswe-read-transporter branch October 9, 2024 23:56
algolia-bot added a commit that referenced this pull request Oct 10, 2024
…skip ci]

Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 10, 2024
algolia/api-clients-automation#3938

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 10, 2024
algolia/api-clients-automation#3938

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 10, 2024
algolia/api-clients-automation#3938

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 10, 2024
algolia/api-clients-automation#3938

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 10, 2024
algolia/api-clients-automation#3938

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 10, 2024
algolia/api-clients-automation#3938

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 10, 2024
algolia/api-clients-automation#3938

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 10, 2024
algolia/api-clients-automation#3938

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 10, 2024
algolia/api-clients-automation#3938

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 10, 2024
algolia/api-clients-automation#3938

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 10, 2024
algolia/api-clients-automation#3938

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: "Write" hosts used for the POST /indexes/{index}/browse operation
4 participants