Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javascript): add every APIs #3942

Merged
merged 14 commits into from
Oct 14, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Oct 10, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3032 https://algolia.atlassian.net/browse/DI-3051

Changes included:

for legacy purposes, algoliasearch only provided a few clients, recommend has been added recently but for consistency with other clients, and easier usage from our customer that leverage multiple products, we can have a single big bundle with every APIs.

the standalone clients are still usable, and dependencies of the algoliasearch client, the lite browser client remains unchanged.

also fixes:

  • bundle the logger-console package, since it's not a dependency, it was never built
  • ci head_ref variable

@shortcuts shortcuts self-assigned this Oct 10, 2024
@shortcuts shortcuts requested a review from a team as a code owner October 10, 2024 11:59
@shortcuts shortcuts marked this pull request as draft October 10, 2024 11:59
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 10, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 40c272f27e29cd4744195fa0af344f07b32f6460
🍃 Generated commit 7f02b7937a79470920688121ab1da41eaf1f9c81
🌲 Generated branch generated/feat/javascript-algoliasearch-add-packages
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1694
go 1619
php 1491
csharp 1360
java 1134
python 1036
ruby 842
swift 765

@shortcuts shortcuts changed the title feat(javascript): add every APIs feat(javascript): add every APIs [skip-bc] Oct 10, 2024
@shortcuts shortcuts force-pushed the feat/javascript-algoliasearch-add-packages branch from 838342f to fc68881 Compare October 14, 2024 08:18
@shortcuts shortcuts marked this pull request as ready for review October 14, 2024 08:53
@shortcuts shortcuts changed the title feat(javascript): add every APIs [skip-bc] feat(javascript): add every APIs Oct 14, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated code looks good !

@shortcuts shortcuts enabled auto-merge (squash) October 14, 2024 13:56
@shortcuts shortcuts merged commit 21d09d3 into main Oct 14, 2024
28 checks passed
@shortcuts shortcuts deleted the feat/javascript-algoliasearch-add-packages branch October 14, 2024 14:13
algolia-bot added a commit that referenced this pull request Oct 14, 2024
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3942

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants