Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): escape char in comments #3973

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix(clients): escape char in comments #3973

merged 1 commit into from
Oct 15, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 15, 2024

🧭 What and Why

Remove all the ugly ` or " that are actually breaking the scala client.

@millotp millotp self-assigned this Oct 15, 2024
@millotp millotp requested a review from a team as a code owner October 15, 2024 13:03
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 15, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 850fb8b10574660be3eb6a2c94528439ef292d95
🍃 Generated commit 638f2ba20b427e0683f16ab4a07698b9ce6ab7d9
🌲 Generated branch generated/fix/escape-strings
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1665
go 1627
php 1544
csharp 1409
java 1101
python 1012
ruby 925
swift 753

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful

@millotp millotp merged commit 162dfaf into main Oct 15, 2024
28 checks passed
@millotp millotp deleted the fix/escape-strings branch October 15, 2024 13:41
algolia-bot added a commit that referenced this pull request Oct 15, 2024
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3973

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3973

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3973

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3973

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 15, 2024
algolia/api-clients-automation#3973

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants