Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): use unknown over any #4011

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Oct 21, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3096

Changes included:

we've converted the any types to unknown lately, but left over some of the generic hardcoded ones

@shortcuts shortcuts self-assigned this Oct 21, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 21, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 014ce38229f07bf7f8dd0fc1eb4abd3d8e819c4d
🍃 Generated commit 2f07ad6244ca9aa45c753926f3bc811fc25e3a39
🌲 Generated branch generated/fix/javascript-unknown-over-any
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1620

@shortcuts shortcuts marked this pull request as ready for review October 21, 2024 12:17
@shortcuts shortcuts requested a review from a team as a code owner October 21, 2024 12:17
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylé

@shortcuts shortcuts merged commit 2c53b45 into main Oct 21, 2024
13 checks passed
@shortcuts shortcuts deleted the fix/javascript-unknown-over-any branch October 21, 2024 12:24
algolia-bot added a commit that referenced this pull request Oct 21, 2024
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 21, 2024
algolia/api-clients-automation#4011

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants